refactor(gc): remove sessions older than 3 hours

...	...		@@ -777,10 +777,6 @@ func jobIDFor(name, workspace string, ts int64) string {
777	777		return fmt.Sprintf("%x", h[:4])
778	778		}
779	779
780		-	func shortSessionName(session, prefix string) string {
781		-	return strings.TrimPrefix(session, prefix)
782		-	}
783		-
784	780		func parseZMXList(output string) []SessionInfo {
785	781		var sessions []SessionInfo
786	782		lines := strings.Split(strings.TrimSpace(output), "\n")

...	...		@@ -906,18 +902,6 @@ func syncArtifacts(cfg Cfg, log slog.Logger) error {
906	902		return nil
907	903		}
908	904
909		-	func filterSessions(sessions []SessionInfo, prefix string) []SessionInfo {
910		-	var filtered []SessionInfo
911		-	for _, s := range sessions {
912		-	if strings.HasPrefix(s.Name, prefix) {
913		-	cs := s
914		-	cs.Short = shortSessionName(s.Name, prefix)
915		-	filtered = append(filtered, cs)
916		-	}
917		-	}
918		-	return filtered
919		-	}
920		-
921	905		func allCompleted(sessions []SessionInfo) bool {
922	906		for _, s := range sessions {
923	907		if s.Ended == "" {

...	...		@@ -1063,7 +1047,7 @@ func killSessions(names []string) error {
1063	1047		return nil
1064	1048		}
1065	1049
1066		-	// runGC deletes completed CI zmx sessions that are not part of a running job.
	1050	+	// runGC kills all ci. zmx sessions older than 3 hours, regardless of status.
1067	1051		func runGC(cfg *Cfg) error {
1068	1052		log := cfg.Logger.With("cmd", "gc")
1069	1053		log.Debug("running garbage collection")

...	...		@@ -1075,33 +1059,26 @@ func runGC(cfg *Cfg) error {
1075	1059
1076	1060		sessions := parseZMXList(string(listOutput))
1077	1061
1078		-	// Group ci. sessions by job prefix: ci.<name>.<jobID>.
1079		-	groups := make(map[string][]SessionInfo)
	1062	+	cutoff := time.Now().Add(-3 * time.Hour).Unix()
	1063	+
	1064	+	var toKill []string
1080	1065		for _, s := range sessions {
1081	1066		if !strings.HasPrefix(s.Name, "ci.") {
1082	1067		continue
1083	1068		}
1084		-	// Extract job prefix: ci.<name>.<jobID>.
1085		-	prefix := extractJobPrefix(s.Name)
1086		-	if prefix == "" {
1087		-	continue
	1069	+
	1070	+	if s.Created == "" {
	1071	+	continue // skip sessions with no creation time
1088	1072		}
1089		-	groups[prefix] = append(groups[prefix], s)
1090		-	}
1091	1073
1092		-	// For each group, if all sessions are completed, kill them.
1093		-	var toKill []string
1094		-	for prefix, group := range groups {
1095		-	allDone := true
1096		-	for _, s := range group {
1097		-	if s.Ended == "" {
1098		-	allDone = false
1099		-	break
1100		-	}
	1074	+	var created int64
	1075	+	if _, err := fmt.Sscanf(s.Created, "%d", &created); err != nil {
	1076	+	continue
1101	1077		}
1102		-	if allDone {
1103		-	log.Debug("completed job, scheduling for gc", "prefix", prefix, "sessions", len(group))
1104		-	toKill = append(toKill, group[0].Name)
	1078	+
	1079	+	if created < cutoff {
	1080	+	log.Debug("session expired, scheduling for gc", "session", s.Name, "created", s.Created)
	1081	+	toKill = append(toKill, s.Name)
1105	1082		}
1106	1083		}
1107	1084

Commit cb4e6af